tests/cgroup: check cgroup.max/cgroup.high values #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihalicyn
force-pushed
the
cgroup2_limits_memory_test
branch
from
77d2844 to
1a7db76
Compare
simondeziel
previously approved these changes
Mar 21, 2024
There was a problem hiding this comment.
LGTM but this seemingly random number got me to scratching my head until I converted 512MiB into bytes ;)
Maybe we should use an expression like
MEM_LIMIT_MIB=512
lxc config set c1 -c limits.memory="${MEM_LIMIT_MIB}MiB"
...
[ "$(lxc exec c1 -- cat /sys/fs/cgroup/memory.max)" = $((MEM_LIMIT_MIB * 1024 * 1024)) ]
...
Update: if you do that ^, we should also replace the hardcoded 524288 kB we have elsewhere.
mihalicyn
force-pushed
the
cgroup2_limits_memory_test
branch
from
1a7db76 to
71a98f0
Compare
|
Thanks, fixed! |
|
It is correct, that test is failed: we need to merge canonical/lxd#13192 |
simondeziel
reviewed
Mar 21, 2024
mihalicyn
force-pushed
the
cgroup2_limits_memory_test
branch
from
71a98f0 to
7728d50
Compare
simondeziel
approved these changes
Mar 21, 2024
mihalicyn
force-pushed
the
cgroup2_limits_memory_test
branch
from
7728d50 to
47fdcc6
Compare
canonical/lxd#13192 Signed-off-by: Alexander Mikhalitsyn <[email protected]>
mihalicyn
force-pushed
the
cgroup2_limits_memory_test
branch
from
47fdcc6 to
197b5d3
Compare
tomponline
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canonical/lxd#13192