-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Add check for refreshing additional snapshots #138
Conversation
f18e9d7
to
f937448
Compare
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can we add similar tests for the storage volume CI tests too (as a separate PR)?
With this change we actually test if a delta of snapshots is transferred accordingly for both local and remote VM copies. Signed-off-by: Julian Pelizäus <[email protected]>
f937448
to
a0025bc
Compare
Absolutely. I'll also add the cross pool migration checks. Thanks for the hint, looks like snapshots of custom volumes are completely missing there until now. |
I have force pushed once more as the LVM thin pool test was exceeding the disk space. So the test now removes the second snapshot after every check to save disk space. Pipeline looks clean now. |
The @roosterfish what do you think of ^? I'd be happy to add it if that makes sense to you (I know very little about snapshot refreshes). |
We start
I like the idea. Maybe just putting files would be easier as we wouldn't need exceptions for the PowerFlex driver in regards to volume size :) |
Sounds good to me! |
With this change we actually test if a delta of snapshots is transferred accordingly for both local and remote VM copies.
Before the refresh was only testing if the volume itself can be refreshed as the number of snapshots on both source and target volume was identical due to the copy operation.
Part of canonical/lxd#13305.