images: Enable arm64 container builds #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Din Music <[email protected]>
Debian, Fedora, openSUSE, Ubuntu, and AlpineLinux (was already disabled). Separate commit, so that we can easily find which images supported VMs. Signed-off-by: Din Music <[email protected]>
tomponline
reviewed
Apr 19, 2024
simondeziel
reviewed
Apr 19, 2024
| build_arm64: | ||
| - ${{ inputs.build-arm64 == true || github.event.schedule == '0 0 * * 1' }} | ||
| exclude: | ||
| - {architecture: amd64, build_arm64: true} |
There was a problem hiding this comment.
This exclude mechanism forcing a double negation is annoying but I don't see how to simplify it.
There was a problem hiding this comment.
Yes I agree, but it is for the same reason as described in #154 (comment).
simondeziel
approved these changes
Apr 19, 2024
tomponline
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable arm64 container image builds.
I've also disabled arm64 image builds for images that require cgroup v1.