Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage bit-for-bit comparison #281

Merged

Conversation

simondeziel
Copy link
Member

No description provided.

@simondeziel simondeziel force-pushed the storage-bit-for-bit-comparison-bis branch 4 times, most recently from 734f569 to bc40523 Compare September 24, 2024 13:19
@simondeziel simondeziel force-pushed the storage-bit-for-bit-comparison-bis branch 5 times, most recently from 0fc3339 to b7b495f Compare September 24, 2024 19:40
Compare the extra part content through `lxc copy` operations

Signed-off-by: Simon Deziel <[email protected]>
Sometimes, `umount`'ing `/boot/efi` on `v2` wouldn't work causing the
comparison to fail as it would compare the checksum with `v1`'s umounted
`/boot/efi`.

Simplify this by always checking that part while mounted.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel simondeziel force-pushed the storage-bit-for-bit-comparison-bis branch from 28eb372 to 45b028f Compare September 24, 2024 21:23
@simondeziel simondeziel marked this pull request as ready for review September 24, 2024 23:03
@simondeziel
Copy link
Member Author

@tomponline all green for the tests/storage-vm test against all snap channels. The execution time is ~30s longer than before.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit 91f32a4 into canonical:main Sep 25, 2024
130 of 136 checks passed
@simondeziel simondeziel deleted the storage-bit-for-bit-comparison-bis branch September 25, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants