Update VM CPU pinning tests for limits.cpu.pin_strategy
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
reviewed
Oct 1, 2024
kadinsayani
force-pushed
the
cpu-auto-pinning-tests
branch
from
00b31d1 to
0cc6f87
Compare
kadinsayani
force-pushed
the
cpu-auto-pinning-tests
branch
2 times, most recently
from
3b1bd4d to
6afbe01
Compare
kadinsayani
changed the title
limits.cpu.pin_strategylimits.cpu.pin_strategy
simondeziel
reviewed
Oct 2, 2024
kadinsayani
force-pushed
the
cpu-auto-pinning-tests
branch
from
6afbe01 to
03982bc
Compare
simondeziel
reviewed
Oct 2, 2024
kadinsayani
force-pushed
the
cpu-auto-pinning-tests
branch
from
03982bc to
bf3a277
Compare
simondeziel
reviewed
Oct 2, 2024
simondeziel
previously approved these changes
Oct 3, 2024
…y` config option Check if feature is present by checking API extension limits_cpu_pin_strategy (landing with Add limits.cpu.pin_strategy setting to disable VM CPU auto pinning by default lxd#14171); and Test VM with auto cpu pinning and no cpu pinning. Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
cpu-auto-pinning-tests
branch
from
bf3a277 to
4d47872
Compare
tomponline
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to
tests/cpu-vm.Changes:
limits_cpu_pin_strategy(landing with Addlimits.cpu.pin_strategysetting to disable VM CPU auto pinning by default lxd#14171);limits.cpu.pin_strategy=autoto check for CPU pinning, andlimits.cpu.pin_strategy=noneto ensure CPU's are not automatically pinned; andlimits.cpu.pin_strategycan't be set while VM is running.