Add testing for OVN uplink attached to VLAN #302
Conversation
boltmark
force-pushed
the
ovn-vlan-uplink-test
branch
3 times, most recently
from
d920bfa to
c43ad03
Compare
boltmark
force-pushed
the
ovn-vlan-uplink-test
branch
2 times, most recently
from
51d2c42 to
6a1b89f
Compare
This PR adds support for OVN uplink networks attached to a VLAN. The implementation details closely track #12234 (comment). Testing here: canonical/lxd-ci#302. Closes #12234.
boltmark
force-pushed
the
ovn-vlan-uplink-test
branch
from
6a1b89f to
e93fec1
Compare
tests/network-ovn
Outdated
| @@ -2154,6 +2205,7 @@ else | |||
| echo "Skipping ovn_l3only_tests, not supported" | |||
| fi | |||
| ovn_leases_tests | |||
| ovn_vlan_uplink_tests | |||
There was a problem hiding this comment.
@boltmark did this test work before canonical/lxd#14196 was merged?
If not then you're going to need to add an API extension please so that the test can detect support for using a bridge network as an uplink with VLAN.
Suggest network_ovn_uplink_vlan
There was a problem hiding this comment.
Hi @tomponline, the test passes on older lxd versions if we keep
bridge vlan add dev lxdbr0 vid 10 tagged self
When it is removed, the test only passes on latest/edge. I suppose we should add the API extension then?
There was a problem hiding this comment.
Yes exactly, thats why we need an API extension check, otherwise you're not testing the functionality in LXD instead the test is just setting up the environment for LXD which defeats the purpose of the test :)
There was a problem hiding this comment.
Got it, thanks! PR for this here: canonical/lxd#14296. Also updated this PR to skip the added test if the extension is not found.
boltmark
force-pushed
the
ovn-vlan-uplink-test
branch
from
e93fec1 to
da7c7e2
Compare
Signed-off-by: Mark Bolton <[email protected]>
boltmark
force-pushed
the
ovn-vlan-uplink-test
branch
from
da7c7e2 to
54f0768
Compare
This PR adds API extension `network_ovn_uplink_vlan`, which adds support for using a bridge network with a specified VLAN ID as the uplink for an OVN network. Related: canonical/lxd-ci#302, #14196.
This PR adds testing for when an OVN uplink network is attached to a VLAN.