Test OVN external addresses show on lxc network list-allocations
#308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
requested changes
Oct 7, 2024
simondeziel
reviewed
Oct 7, 2024
hamistao
force-pushed
the
list-ovn-routers_tests
branch
from
19cf499 to
78dcfe3
Compare
simondeziel
reviewed
Oct 7, 2024
hamistao
force-pushed
the
list-ovn-routers_tests
branch
from
78dcfe3 to
483aec9
Compare
simondeziel
previously approved these changes
Oct 7, 2024
hamistao
force-pushed
the
list-ovn-routers_tests
branch
from
483aec9 to
8c4a89f
Compare
simondeziel
reviewed
Oct 17, 2024
tests/network-ovn
Outdated
Comment on lines
2106
to
2109
| ovn_ext_ipv4="$(lxc network get ovn-virtual-network volatile.network.ipv4.address)" | ||
| ovn_ext_ipv6="$(lxc network get ovn-virtual-network volatile.network.ipv6.address)" | ||
| lxc network list-allocations --format csv | grep -F "/1.0/networks/ovn-virtual-network,${ovn_ext_ipv4}" | ||
| lxc network list-allocations --format csv | grep -F "/1.0/networks/ovn-virtual-network,${ovn_ext_ipv6}" |
There was a problem hiding this comment.
s/ovn-virtual-network/ovn/?
Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
list-ovn-routers_tests
branch
from
8c4a89f to
276bc70
Compare
|
@tomponline Sorry, should have pinged you after canonical/lxd#14210 was merged. |
|
@hamistao lets wait until canonical/lxd#14305 is merged and this PR is updated to reflect it. |
|
@tomponline Just a reminder on this PR's history. We hadn't merged it yet because canonical/lxd#14305 could potentially require additional tests that could be added here. But since that PR it is now closed, this should be ready to review (and hopefully merge). |
tomponline
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on canonical/lxd#14210