Build and test images

[MusicDin]

Adds workflows for building and testing lxd-imagebuilder images.

TODO:

• setup-image contains url to the fork of the lxd-ci, which allows easier testing until recipes are ready.
• Virtualization is not enabled (LXD reports drivers: "lxc")
• If one reusable workflow fails, it stops all other workflows of the same image distro.
• Prevent image upload if VM tests were skipped

[simondeziel]

Please replace all those by a single top section:

defaults:
  run:
    # Make sure bash is always invoked with `-eo pipefail`
    # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
    shell: bash

[MusicDin]

I've tried this one, but composite actions do not support default.run.shell.

[simondeziel]

Oh bummer. Have you tried putting it in the top composite job?

[simondeziel]

workflow_dispatch: would be handing to trigger those workflows on demand.

[MusicDin]

Will add. Currently, this is added only for each separate image action.

[MusicDin]

Also, do we want to run those on "push" and "pull_request"? I would expect only workflow_dispatch and cron? Because once we add all images this will most likely trigger few hundred builds.

[simondeziel]

This is a call for Tom to make but I think we'll at least want cron and manual dispatch. I think you are right in that we should avoid the thundering herd on pull/push :)

[tomponline]

Also, do we want to run those on "push" and "pull_request"? I would expect only workflow_dispatch and cron? Because once we add all images this will most likely trigger few hundred builds.

Yes indeed, daily and manually only.
We could potentially do something cleverer later where we detect if a pull request has modified recipe(s) and then runs the rebuild of only those modified in the PR.

[simondeziel]

I like those composite jobs, pretty nifty. You might want to also include some steps to replicate https://github.com/canonical/lxd-ci/blob/main/.github/workflows/tests.yml#L83-L122

[simondeziel]

@MusicDin fedora 36 is EOL, 39 is where it's at now ;)

[MusicDin]

Moving to LXD-CI.