Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: update CI to run most tests with Go 1.21 with build/compat test with 1.19 (stable-5.0) #12877

Merged
merged 16 commits into from
Feb 13, 2024
Merged

github: update CI to run most tests with Go 1.21 with build/compat test with 1.19 (stable-5.0) #12877

merged 16 commits into from
Feb 13, 2024

Conversation

simondeziel
Copy link
Member

Backport of #12822 to stable-5.0

@simondeziel
github: run system-tests with LXD built with Go 1.21
94c5620 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 08da388)
@simondeziel
github: run some system-tests with LXD built with Go 1.19
ea1a1db 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit c45ac17)
@simondeziel
github: use matrix.go in Install Go section names
6d244ab 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 6344260)
@simondeziel
github: check compat with min Go version when compiling with 1.19.x
6e168c7 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 17c7d2d)
@simondeziel
github: run code tests using Go 1.21.x
eb17c81 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit e687097)
@simondeziel
github: stop purging core20
7395af2 
This was risky because if another snap (like mdl) moved to a core20 base, we'd
be removing core20 just to download it again.

Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 3491b6e)
@simondeziel
github: purge disabled/superseded snaps
a43e3fd 
This is to reclaim some space.

Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 875480c)
@simondeziel
github: build all client binaries with Go 1.21
0304bae 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 14a416c)
@simondeziel
github: build doc with Go 1.21
aac6ffc 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 0a16fe1)
@simondeziel
github: build lxd-snapcraft with Go 1.21
e53e8c8 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 4fd1164)
@simondeziel
github: hardcode Go version used with code-tests/documentation
967a510 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 2ed790c)
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Feb 12, 2024
@simondeziel simondeziel changed the base branch from main to stable-5.0 February 12, 2024 20:25
@github-actions github-actions bot removed Documentation Documentation needs updating API Changes to the REST API labels Feb 12, 2024
@simondeziel
Copy link
Member Author

I can't find a way to pin minio to v7.0.66 as v7.0.67 no longer builds with Go 1.19 (minio/minio-go#1931):

$ make update-gomod 
go get -t -v -d -u ./...
go: trying upgrade to github.com/mdlayher/[email protected]
go: accepting indirect upgrade from [email protected] to 1.21
go: upgraded go 1.19 => 1.21
go: added toolchain go1.21.6
go: upgraded github.com/mdlayher/socket v0.4.1 => v0.5.0
go get github.com/mdlayher/[email protected]
go: downgraded github.com/mdlayher/socket v0.5.0 => v0.4.1
# https://github.com/minio/minio-go/issues/1931
go get github.com/minio/[email protected]
go: github.com/minio/[email protected]: invalid version: go.mod has post-v7 module path "github.com/minio/minio-go/v7" at revision v7.0.66
make: *** [Makefile:95: update-gomod] Error 1

@simondeziel simondeziel marked this pull request as ready for review February 12, 2024 21:36
@masnax
Copy link
Contributor

masnax commented Feb 12, 2024 •
edited
Loading

I think you just need

replace github.com/minio/minio-go/v7 => github.com/minio/minio-go/v7 v7.0.66

before the first require block in go.mod, then just a make update-gomod should work.

@simondeziel
github: move snap removal to "Reclaim some space" step
80bff10 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit b765613)
@simondeziel
github: put docker removal its own step
37349f2 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit 117e76b)
@simondeziel
github: mask lxc{,-net}.service in a singe command
3231368 
Signed-off-by: Simon Deziel <[email protected]>
(cherry picked from commit d5c5c7d)
@simondeziel
go.mod: pin minio-go to v7.0.66 (minio/minio-go#1931)
9f4a30f 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
gomod: Update dependencies
7e32349 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
Copy link
Member Author

@masnax thank you that did it!

@tomponline tomponline merged commit 7958df7 into canonical:stable-5.0 Feb 13, 2024
27 checks passed
@simondeziel simondeziel deleted the ci-1.21-stable-5.0 branch February 13, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simondeziel @masnax @tomponline