Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openfga dependency update #13780

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Openfga dependency update #13780

merged 7 commits into from
Jul 22, 2024

Conversation

hamistao
Copy link
Contributor

@hamistao hamistao commented Jul 17, 2024

Closes #13667 by updating openfga to version 1.5.6.

@hamistao hamistao force-pushed the openfga-update branch 2 times, most recently from 86ac3e5 to 2a7fda1 Compare July 17, 2024 22:42
@hamistao hamistao changed the title Openfga update Go version and dependency update (openfga 1.5.6 included) Jul 17, 2024
@github-actions github-actions bot added the Documentation Documentation needs updating label Jul 17, 2024
Copy link

Heads up @ru-fu - the "Documentation" label was applied to this issue.

@hamistao hamistao force-pushed the openfga-update branch 4 times, most recently from 626d507 to 8cd2e49 Compare July 19, 2024 13:48
@hamistao hamistao marked this pull request as ready for review July 19, 2024 14:26
@hamistao hamistao requested a review from tomponline July 19, 2024 14:27
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a request to only update the specific go mods please

@hamistao hamistao marked this pull request as draft July 19, 2024 19:11
@hamistao hamistao changed the title Go version and dependency update (openfga 1.5.6 included) Openfga update Jul 19, 2024
@hamistao hamistao changed the title Openfga update Openfga dependency update Jul 19, 2024
@hamistao hamistao force-pushed the openfga-update branch 3 times, most recently from 04e0ef8 to de494bc Compare July 19, 2024 20:38
@hamistao hamistao marked this pull request as ready for review July 20, 2024 01:52
hamistao and others added 4 commits July 21, 2024 10:56
Signed-off-by: hamistao <[email protected]>
…dStartingWithUser`

Previously this method expected there to be only one user filter.
OpenFGA is now also passing in a filter for a type-bound public access
where applicable in the model. Here I have performed the same
optimisation is in `ReadUsersetTuples` to handle the case.

Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: hamistao <[email protected]>
markylaing and others added 3 commits July 21, 2024 10:56
Previously this method expected there to be only one user filter.
OpenFGA is now also passing in a filter for a type-bound public access
where applicable in the model. Here I have performed the same
optimisation is in `ReadUsersetTuples` to handle the case.

Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: hamistao <[email protected]>
@tomponline tomponline merged commit 139203d into canonical:main Jul 22, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(deps): update github.com/openfga/api/proto digest to f5a955a #13649
3 participants