-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openfga dependency update #13780
Merged
Merged
Openfga dependency update #13780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86ac3e5
to
2a7fda1
Compare
Heads up @ru-fu - the "Documentation" label was applied to this issue. |
626d507
to
8cd2e49
Compare
tomponline
reviewed
Jul 19, 2024
tomponline
reviewed
Jul 19, 2024
tomponline
approved these changes
Jul 19, 2024
tomponline
reviewed
Jul 19, 2024
tomponline
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a request to only update the specific go mods please
04e0ef8
to
de494bc
Compare
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
…dStartingWithUser` Previously this method expected there to be only one user filter. OpenFGA is now also passing in a filter for a type-bound public access where applicable in the model. Here I have performed the same optimisation is in `ReadUsersetTuples` to handle the case. Signed-off-by: Mark Laing <[email protected]> Signed-off-by: hamistao <[email protected]>
Previously this method expected there to be only one user filter. OpenFGA is now also passing in a filter for a type-bound public access where applicable in the model. Here I have performed the same optimisation is in `ReadUsersetTuples` to handle the case. Signed-off-by: Mark Laing <[email protected]> Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
tomponline
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13667 by updating openfga to version 1.5.6.