lxd: Add virtio-blk support for virtual machines (from Incus) #13905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up @mionaalex - the "Documentation" label was applied to this issue. |
github-actions
bot
added
Documentation
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 61b718d77c2a188279e617fde44608b27eaa454b) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit 6938b423a41847016bb448d88a4af85858b0d12c) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]> (cherry picked from commit f127b7aa631e7fe6304ea139ccc44f2dec71e895) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
kadinsayani
force-pushed
the
incus-384-cherry-pick
branch
2 times, most recently
from
7756bb8 to
ed6d5a0
Compare
…ce() Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
|
@kadinsayani did you test this worked btw? |
Yes, adding a new disk device to a virtual machine with the |
tomponline
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Ta. Please can you add tests for this to lxd-ci storage vm tests. @markylaing can help you with this if needed. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked from lxc/incus#384