Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches: Fix spelling error in instance snapshot deletion trigger name #14043

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Patches: Fix spelling error in instance snapshot deletion trigger name #14043

merged 2 commits into from
Sep 12, 2024

Conversation

kadinsayani
Copy link
Contributor

Fixes #13862

@kadinsayani kadinsayani changed the title 13862 spelling error instance snapshot deletion Patches: Fix spelling error in instance snapshot deletion trigger name Sep 4, 2024
@kadinsayani kadinsayani force-pushed the 13862-spelling-error-instance-snapshot-deletion branch from cbd5d1c to e5f0560 Compare September 4, 2024 16:00
@kadinsayani
Copy link
Contributor Author

@markylaing I'm using DROP TRIGGER IF EXISTS here. Please let me know if you think it would be better to query for the trigger name before attempting to apply the patch.

markylaing
markylaing reviewed Sep 5, 2024
View reviewed changes
lxd/patches.go Outdated Show resolved Hide resolved
markylaing
markylaing reviewed Sep 5, 2024
View reviewed changes
lxd/patches.go Outdated Show resolved Hide resolved
@kadinsayani kadinsayani force-pushed the 13862-spelling-error-instance-snapshot-deletion branch 3 times, most recently from 7fcb4c0 to 4f24075 Compare September 9, 2024 19:15
@kadinsayani kadinsayani force-pushed the 13862-spelling-error-instance-snapshot-deletion branch from 4f24075 to af8e15a Compare September 9, 2024 19:29
@tomponline
Copy link
Member

@markylaing are you happy with this one?

markylaing
markylaing approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@markylaing markylaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@tomponline tomponline merged commit 016fbc8 into canonical:main Sep 12, 2024
29 checks passed
@kadinsayani kadinsayani deleted the 13862-spelling-error-instance-snapshot-deletion branch September 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markylaing markylaing markylaing approved these changes

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spelling error in instance snapshot deletion trigger name
3 participants
@kadinsayani @tomponline @markylaing