Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated storage volume doc to remove any suspicion of action not working #14080

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

escabo
Copy link
Contributor

@escabo escabo commented Sep 10, 2024

No description provided.

@github-actions github-actions bot added the Documentation Documentation needs updating label Sep 10, 2024
Copy link

Heads up @mionaalex - the "Documentation" label was applied to this issue.

Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To fix the DCO check, please add your Signed-off-by. git commit --amend -s should do and then a forced push.

@escabo
Copy link
Contributor Author

escabo commented Sep 10, 2024

LGTM. To fix the DCO check, please add your Signed-off-by. git commit --amend -s should do and then a forced push.

rookie mistake.

@escabo escabo closed this Sep 10, 2024
@simondeziel simondeziel reopened this Sep 10, 2024
@tomponline tomponline merged commit 65ccfda into canonical:main Sep 10, 2024
28 checks passed
@escabo escabo deleted the storage_volume_doc branch September 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants