CLI: Exclude default remote from lxc remote switch|remove shell completions
#14677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadinsayani
force-pushed
the
remote-switch-completion-fix
branch
from
c238785 to
1ca313e
Compare
kadinsayani
changed the title
lxc remote switch|removelxc remote switch|remove shell completions
simondeziel
reviewed
Dec 17, 2024
…` completions Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
remote-switch-completion-fix
branch
from
1ca313e to
e6b170c
Compare
simondeziel
approved these changes
Dec 17, 2024
tomponline
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 1/2 issues raised in #14635.
This PR adds logic to exclude the default (current) remote from shell completions when running
lxc remote switch|remove. As described in this comment, it appears thatsnapdis intercepting the response and excluding non-default remotes (cdimagein this case). I'll see if I can land a fix for the second issue in https://github.com/canonical/lxd-pkg-snap.