VM: Fix live migration #14696
Merged
VM: Fix live migration #14696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d734721. Breaks VM live migration. Signed-off-by: Thomas Parrott <[email protected]>
…ntainer" This reverts commit dbead14. We reverted the qemu equivalent as it broke VM live migration so reverting this too. Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
…ances in Render Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
…nces in Render Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
hamistao
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #14539 broke live migration in commit d734721
This is because when live migrating a VM, the VM's
Start()function is called on the target side (so that live migration can occur) before the Location of the instance is updated in the DB. This in turn callsstatusCodeduring the start process.The change to the
statusCodefunction meant that this returned an error status because the instance was in theory non-local, and that prevented the qemu process from being started.This PR reverts the
statusCodeerror change and moves that logic into the Render function.Fixes #14679