CLI: lxc storage volume completion fixes and command description update
#14702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadinsayani
force-pushed
the
14682-storage-volume-completion-fixes
branch
2 times, most recently
from
f05c7f7 to
fed5f9d
Compare
…e show` Fixes canonical#14682. This commit fixes shell completions for snapshots when running `lxc storage volume show`. `GetStoragePoolVolumeNames` returns the full volume name including "/snapshots/", which is incorrect in the context of the CLI. Signed-off-by: Kadin Sayani <[email protected]> (cherry picked from commit 1bcc8b3)
…tion The command is `lxc storage volume snapshot <pool> <volume>` not `lxc storage volume snapshot create <pool> <volume>` Signed-off-by: Kadin Sayani <[email protected]> (cherry picked from commit 5a669ef)
Signed-off-by: Kadin Sayani <[email protected]> (cherry picked from commit b67bf1a)
kadinsayani
force-pushed
the
14682-storage-volume-completion-fixes
branch
from
b6bd50a to
3ad34fc
Compare
simondeziel
previously approved these changes
Dec 19, 2024
tomponline
reviewed
Dec 20, 2024
tomponline
reviewed
Dec 20, 2024
tomponline
reviewed
Dec 20, 2024
tomponline
requested changes
Dec 20, 2024
After the addition of improved configuration key validation with #14584, we don't actually need any validation in |
…g keys This commit fixes `cmpInstanceSetKeys` to return any set instance configuration key rather than just keys with known prefixes. We don't need to validate type here since a VM specific config key cannot be set for a container, and vice-versa, and we only return config keys that show up in an instance's full config. Signed-off-by: Kadin Sayani <[email protected]> (cherry picked from commit 4307f76)
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
14682-storage-volume-completion-fixes
branch
from
12f5d43 to
dbc4c86
Compare
I've removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14682.
Summary of changes:
lxc storage volume show.GetStoragePoolVolumeNamesreturns the full volume name including "/snapshots/", which is incorrect in the context of the CLI. To address this issue, parsing has been added to serve valid completions for snapshot volumes.lxc storage volume snapshot.cmpInstanceSetKeyslogic to provide completions for any instance keys which are currently set, not just prefixed keys.