Storage: Add reverter to disk device update & test #14703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MggMuggins
force-pushed
the
add-reverter-to-storage-pool-update
branch
from
b4567c0 to
0c554c7
Compare
tomponline
reviewed
Dec 20, 2024
tomponline
reviewed
Dec 20, 2024
tomponline
reviewed
Dec 20, 2024
So that the old ones are still around for use in a reverter Signed-off-by: Wesley Hershberger <[email protected]>
storagePoolVolumeUpdateUsers is used in two places, one of which does not currently use a reverter. If that update fails, the instances/profiles could be left in an inconsistent state. This pushes the reverter inside the function, so that it is safe to call without needing a reverter. My hunch is that this is also slightly less slow in case of failure. Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Ensure that renaming local storage volumes in a clustered context doesn't break horribly. This features is clearly not a thoroughly planned semantic corner. We should consider removing it entirely. Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
force-pushed
the
add-reverter-to-storage-pool-update
branch
from
0c554c7 to
6a28fde
Compare
tomponline
approved these changes
Dec 20, 2024
tomponline
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
storagePoolVolumeUpdateUserssafe to call without using a reverter.This also adds a few tests around renaming attached local custom storage volumes in a clustered context. As we've discussed previously (#14681), updating disk devices in profiles isn't necessarily sound. These tests give me a little more confidence that updates behave sanely for local storage volumes in a cluster.
We should consider eliminating this feature altogether and simply making it a hard error to rename a custom storage volume while it is referred to by any disk device.