-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mutating webhook #352
Open
Gu1nness
wants to merge
9
commits into
6/edge
Choose a base branch
from
add-webhook-container
base: 6/edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4d41725
update metadata.yaml
MiaAltieri 7f623c6
add infrastructure for starting the service
MiaAltieri 865b1b5
WIP attemping to register webhook to k8s
MiaAltieri 3a9ced3
wip: more fixes
Gu1nness 8a2e72f
wip: code part
Gu1nness 8e61e97
wip: test part
Gu1nness e7422b6
fix: refacto + post-rebase issues
Gu1nness f732d9d
move cert generation to an earlier bit
MiaAltieri 8aee132
fix most unit tests, comment out rest
MiaAltieri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
#!/usr/bin/env python3 | ||
"""Generates a self signed certificate for the mutating webhook.""" | ||
# Copyright 2024 Canonical Ltd. | ||
# See LICENSE file for licensing details. | ||
import datetime | ||
|
||
from cryptography import x509 | ||
from cryptography.hazmat.backends import default_backend | ||
from cryptography.hazmat.primitives import hashes, serialization | ||
from cryptography.hazmat.primitives.asymmetric import rsa | ||
from cryptography.x509.oid import NameOID | ||
|
||
|
||
def gen_certificate(app_name: str, ns: str) -> tuple[bytes, bytes]: | ||
"""Generates a tuple of cert and key for the mutating webhook.""" | ||
one_day = datetime.timedelta(1, 0, 0) | ||
private_key = rsa.generate_private_key( | ||
public_exponent=65537, key_size=2048, backend=default_backend() | ||
) | ||
public_key = private_key.public_key() | ||
|
||
builder = x509.CertificateBuilder() | ||
builder = builder.subject_name(x509.Name([x509.NameAttribute(NameOID.COMMON_NAME, app_name)])) | ||
builder = builder.issuer_name(x509.Name([x509.NameAttribute(NameOID.COMMON_NAME, ns)])) | ||
builder = builder.not_valid_before(datetime.datetime.today() - one_day) | ||
builder = builder.not_valid_after(datetime.datetime.today() + (one_day * 365 * 100)) | ||
builder = builder.serial_number(x509.random_serial_number()) | ||
builder = builder.public_key(public_key) | ||
builder = builder.add_extension( | ||
x509.SubjectAlternativeName( | ||
[ | ||
x509.DNSName(f"{app_name}.{ns}.svc"), | ||
] | ||
), | ||
critical=False, | ||
) | ||
builder = builder.add_extension( | ||
x509.BasicConstraints(ca=False, path_length=None), critical=True | ||
) | ||
|
||
certificate = builder.sign( | ||
private_key=private_key, algorithm=hashes.SHA256(), backend=default_backend() | ||
) | ||
|
||
return ( | ||
certificate.public_bytes(serialization.Encoding.PEM), | ||
private_key.private_bytes( | ||
serialization.Encoding.PEM, | ||
serialization.PrivateFormat.PKCS8, | ||
serialization.NoEncryption(), | ||
), | ||
) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice :)