-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point In Time Recovery #531
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # lib/charms/mysql/v0/mysql.py
|
# Conflicts: # lib/charms/mysql/v0/mysql.py
# Conflicts: # lib/charms/mysql/v0/mysql.py
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def get_cluster_members(self) -> list[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use _get_cluster_member_addresses
instead of creating a new method. It's tried and tested, and don't have the name resolution issue reported privately
if self.container.exists(MYSQL_BINLOGS_COLLECTOR_CONFIG_FILE): | ||
self.container.remove_path(MYSQL_BINLOGS_COLLECTOR_CONFIG_FILE) | ||
|
||
def get_cluster_members(self) -> list[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as this
"default_region": s3_parameters["region"], | ||
}, | ||
}) | ||
self.charm._mysql.write_content_to_file( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another way to configure the binlog collector so to avoid writting s3 secret-key
to disk?
@@ -133,7 +134,7 @@ def wait_until_mysql_connection(self) -> None: | |||
# Increment this major API version when introducing breaking changes | |||
LIBAPI = 0 | |||
|
|||
LIBPATCH = 80 | |||
LIBPATCH = 81 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 Please remember to rebase your PR from main
once all comments have been addressed.
LIBPATCH for this charm lib was bumped to 81
in this PR already.
mysql_user=SERVER_CONFIG_USERNAME, | ||
password=self.charm.get_secret("app", SERVER_CONFIG_PASSWORD_KEY), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user always need to be super user, you can simplify _pitr_restore
method to have the user in it, using the user and password attributes from the self object in MySQL
class instance
Important!
This PR relies on the last version of charmed-mysql-snap and canonical/charmed-mysql-snap#62. Also, it's a copy of the VM PR.
Overview
MySQL stores binary transactions logs. This PR adds a service job to upload these logs to the S3 bucket and the ability to use them later for a point-in-time-recovery with a new
restore-to-time
parameter during restore. This new parameter accepts MySQL timestamp or keywordlatest
(for replaying all the transaction logs).Also, a new application blocked status is introduced -
Another cluster S3 repository
to signal user that used S3 repository is claimed by the another cluster and binlogs collecting job is disabled and creating new backups is restricted (these are the only workload limitation). This is crucial to keep stored binary logs safe from the another clusters. This check uses@@GLOBAL.group_replication_group_name
.After restore, cluster group replication is reinitialized, so practically it becomes a new different cluster. For these cases,
Another cluster S3 repository
message is changed to theMove restored cluster to another S3 repository
to indicate this event more conveniently for the user.Both the block messages will disappear when S3 configuration is removed or changed to the empty repository.
Usage example
juju run mysql/leader restore backup-id=2024-11-20T17:08:24Z restore-to-time="2024-11-20 17:10:01"
juju run mysql/leader restore backup-id=2024-11-20T17:08:24Z restore-to-time="latest"
Key notes