fix: DPE-6521 Add missing check and wait for pebble calls #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomach
commented
Feb 4, 2025
| @@ -144,3 +144,5 @@ Makefile | |||
|
|
|||
| # local pyright settings | |||
| pyrightconfig.json | |||
|
|
|||
| wt*/ | |||
There was a problem hiding this comment.
included to ignore worktree dirs
paulomach
requested review from
shayancanonical,
carlcsaposs-canonical,
taurus-forever and
sinclert-canonical
and removed request for
shayancanonical
carlcsaposs-canonical
approved these changes
Feb 4, 2025
shayancanonical
approved these changes
Feb 4, 2025
sinclert-canonical
approved these changes
Feb 4, 2025
| def unit_initialized(self) -> bool: | ||
| """Return whether a unit is started. | ||
|
|
||
| Oveerride parent class method to include container accessibility check. |
There was a problem hiding this comment.
Suggested change
| Oveerride parent class method to include container accessibility check. | |
| Override parent class method to include container accessibility check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
waitfor the process (call is not executed)Solution
Add said calls.