Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update kfp driver to version 2.4.0 #175

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

misohu
Copy link
Member

@misohu misohu commented Feb 10, 2025

Coparison 2.2.0 to 2.4.0 https://www.diffchecker.com/oocOlcuJ/

Changes

  • go version plus the extra build arg
  • removed appuser (based on other rocks)

@misohu misohu changed the title Kf 6881 kfp driver 2 4 0 feat: update kfp driver to version 2.4.0 Feb 10, 2025
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @misohu, I tried running the rock with docker run kfp-driver:2.4.0 and I am seeing in the logs:

2025-02-12T08:24:57.876Z [pebble] Change 1 task (Start service "launcher") failed: cannot start service: fork/exec /bin/driver: operation not permitted

Is it expected to run it with --user rather?
I think we should check what is the command that is being run for the driver container when creating a pipeline and use it to test here. Can you add test instructions with that? thanks!

driver/rockcraft.yaml Outdated Show resolved Hide resolved
@misohu
Copy link
Member Author

misohu commented Feb 12, 2025

After syncing with @NohaIhab and @DnPlas we decided to remove the appuser from the rock. We are not using the user in other rocks. This allows us to always run the service as daemon

Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @misohu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants