Switch naming to HostMetricsMissing for absent metrics

canonical · Dec 20, 2024 · 48e9ce8 · 48e9ce8
1 parent 1b35ab8
commit 48e9ce8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/charms/prometheus_k8s/v0/prometheus_scrape.py b/lib/charms/prometheus_k8s/v0/prometheus_scrape.py
@@ -413,19 +413,19 @@ def _on_scrape_targets_changed(self, event):
               annotations:
                 summary: Host '{{ $labels.instance }}' is down.
                 description: >-
-                  Host '{{ $labels.instance }}' is down.
+                  Host '{{ $labels.instance }}' is down, failed to scrape.
                     VALUE = {{ $value }}
                     LABELS = {{ $labels }}
-            - alert: HostUnavailable
+            - alert: HostMetricsMissing
               # This alert is applicable only when the provider is linked via an aggregator (such as grafana agent)
               expr: absent(up)
               for: 5m
               labels:
                 severity: critical
               annotations:
-                summary: Metrics not received from host '{{ $labels.instance }}'.
+                summary: Metrics not received from host '{{ $labels.instance }}', failed to remote write.
                 description: >-
-                  Metrics not received from host '{{ $labels.instance }}'.
+                  Metrics not received from host '{{ $labels.instance }}', failed to remote write.
                     VALUE = {{ $value }}
                     LABELS = {{ $labels }}
         """

diff --git a/lib/charms/prometheus_k8s/v1/prometheus_remote_write.py b/lib/charms/prometheus_k8s/v1/prometheus_remote_write.py
@@ -67,15 +67,15 @@
         groups:
           - name: AggregatorHostHealth
             rules:
-            - alert: HostUnavailable
+            - alert: HostMetricsMissing
               expr: absent(up)
               for: 5m
               labels:
                 severity: critical
               annotations:
-                summary: Metrics not received from host '{{ $labels.instance }}'.
+                summary: Metrics not received from host '{{ $labels.instance }}', failed to remote write.
                 description: >-
-                  Metrics not received from host '{{ $labels.instance }}'.
+                  Metrics not received from host '{{ $labels.instance }}', failed to remote write.
                     VALUE = {{ $value }}
                     LABELS = {{ $labels }}
         """