Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update charm libraries #518

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Update charm libraries #518

merged 1 commit into from
Sep 23, 2023

Conversation

observability-noctua-bot
Copy link
Contributor

Automated action to fetch latest version of charm libraries. The branch of this PR
will be wiped during the next check. Unless you really know what you're doing, you
most likely don't want to push any commits to this branch.

@sed-i
Copy link
Contributor

sed-i commented Sep 5, 2023

The IPU update is needed to fix this common problem:

prom/0*  error     idle   10.1.166.84          hook failed: "certificates-relation-changed" for ca:certificates

  File "./src/charm.py", line 410, in _on_server_cert_changed
    self.ingress.provide_ingress_requirements(
  File "/var/lib/juju/agents/unit-prom-0/charm/lib/charms/traefik_k8s/v1/ingress_per_unit.py", line 801, in provide_ingress_requirements
    assert self.relation, "no relation"
AssertionError: no relation

@observability-noctua-bot observability-noctua-bot force-pushed the chore/auto-libs branch 4 times, most recently from 2f410d7 to 6781e2d Compare September 21, 2023 20:01
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 21, 2023
View reviewed changes
lib/charms/observability_libs/v0/cert_handler.py
logger.info("Creating CSR for %s with DNS %s", self.cert_subject, self.sans_dns)
logger.info(
"Creating CSR for %s with DNS %s and IPs %s",
self.cert_subject,

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (certificate)](1) as clear text.
@observability-noctua-bot observability-noctua-bot force-pushed the chore/auto-libs branch 2 times, most recently from e09f226 to 5eb5579 Compare September 22, 2023 16:08
@sed-i sed-i merged commit 656fdbe into main Sep 23, 2023
@sed-i sed-i deleted the chore/auto-libs branch September 23, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@lucabello lucabello Awaiting requested review from lucabello

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@dstathis dstathis Awaiting requested review from dstathis

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@observability-noctua-bot @sed-i