Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ActiveStatus when retention size config option is valid #561

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

sed-i
Copy link
Contributor

@sed-i sed-i commented Jan 17, 2024

Issue

BlockedStatus from an invalid retention size config option was never cleared.

Solution

  • Add a TypedDict for per-component status setting.
  • Use the per-component status dict to set status centrally in _configure.

Fixes #560.

src/charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/charm.py Outdated Show resolved Hide resolved
@sed-i sed-i force-pushed the feature/fix-status branch from 1893258 to fd2c84d Compare January 26, 2024 04:38
Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach is interesting and looks good. Just a couple of nit comments.

src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@sed-i sed-i merged commit 4ca83b6 into main Jan 29, 2024
13 checks passed
@sed-i sed-i deleted the feature/fix-status branch January 29, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck on BlockedStatus even after maximum_retention_size config option changed to valid
3 participants