Fix topology for self-scraping #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simskij
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
PietroPasotti and
sed-i
as code owners
dstathis
approved these changes
Jan 25, 2024
|
@PietroPasotti any idea why the scenario tests would fail because of this? seems unrelated, but main is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, we populate the unit name label with the charm name, and discard the unit name.
Solution
juju_unitthe unit name.juju_charmand store the charm name there.Context
N/A
Testing Instructions
Check the labels for Prometheus
up1 and make sure it has the right values.Release Notes
Apply the correct Juju topology while self-scraping.