-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use external_url in alert source #635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cough tests cough
A unit test has been fixed :) I also skipped the tests we were XFail-ing, because they'll just waste time in integration tests without contributing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle the change is OK and given it's high prio I don't want to block it, but we're skipping a huge amount of tests for unclear reasons.
Can you explain what's going on and remove any tests that are no longer necessary?
Issue
Closes #581.
Closes canonical/alertmanager-k8s-operator#206.
Not sure why we were using the
route_prefix
from theself.external_url
(from ingress), but adding it to theself.internal_url
(which is always the FQDN).Solution
Use the external URL instead of the internal one.
Screenshots
Before:
After:
Testing Instructions
Upgrade Notes
Anything that refreshes the Pebble plan will activate this change, so the upgrade should be seamless.