Test against 4.0/edge on 22.04
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 32 32
Lines 3159 3159
=======================================
Hits 3044 3044
Misses 115 115 ☔ View full report in Codecov by Sentry. |
simondeziel
dismissed
hamistao’s stale review
The merge-base changed after approval.
Oh, that's probably why it didn't let me merge despite your initial ack. Indeed let me clean that up. I thought it would be smart enough to do it automatically... |
Python 3.8 was picked as it's the default python3 version on 20.04. Signed-off-by: Simon Deziel <[email protected]>
Python 3.11 makes little sense now that we test with 3.12. Also, 3.11 isn't shipped in any Ubuntu LTS version (just 23.10). Signed-off-by: Simon Deziel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#592 is a prerequisite
This PR is expected to fail until #590 is addressed.