Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean remote application when disabling observability #215

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

gboutry
Copy link
Collaborator

@gboutry gboutry commented Apr 24, 2024

Clean remote applications coming from observability model when disabling observability plugin.

LP: 2063183

@hemanthnakkina
Copy link
Collaborator

Is this supposed to handle by terraform-provider-juju?
Earlier it used to remove remote offers but i changed the code to remove integration to handle the case of multiple consumers. juju/terraform-provider-juju#309

Initially i thought to remove remote offer based on number of consumers but did not do it as all the consumers can be deleted in parallel in terraform.

Can we raise a bug at terraform-provider-juju and mention it as a comment in the code?

Clean remote applications coming from observability model when disabling
observability plugin.

LP: 2063183
@gboutry gboutry force-pushed the fix/re-enable-observability branch from 3a4f31c to e03eba0 Compare April 25, 2024 08:17
@gboutry
Copy link
Collaborator Author

gboutry commented Apr 25, 2024

Is this supposed to handle by terraform-provider-juju? Earlier it used to remove remote offers but i changed the code to remove integration to handle the case of multiple consumers. juju/terraform-provider-juju#309

Initially i thought to remove remote offer based on number of consumers but did not do it as all the consumers can be deleted in parallel in terraform.

Can we raise a bug at terraform-provider-juju and mention it as a comment in the code?

PR updated with mention to: juju/terraform-provider-juju#473

@hemanthnakkina hemanthnakkina merged commit 71c09bd into canonical:main Apr 25, 2024
4 checks passed
@gboutry gboutry deleted the fix/re-enable-observability branch April 25, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants