Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher header consistency #4485

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Lukewh
Copy link
Contributor

@Lukewh Lukewh commented Dec 12, 2023

Done

Ensured the headers for all publisher pages are consistent

  • Added some extra data to certain pages and views
  • Updated navigation.js to set the users displayname in session storage
  • Updated PageHeader component to conditionally show "By [publishername]" based on the session storage display name

How to QA

  • Visit a snap you own, go through the publisher pages
    • Make sure the header shows the snap title, not the snap name
  • Visit a snap you don't own, go through each publisher page
    • Make sure the header shows the snap title and "by [publishername]"

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-7927

Screenshots

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4485.demos.haus

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (615acb6) 79.79% compared to head (a04b70f) 79.79%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4485   +/-   ##
=======================================
  Coverage   79.79%   79.79%           
=======================================
  Files         207      207           
  Lines       10472    10474    +2     
  Branches      924      926    +2     
=======================================
+ Hits         8356     8358    +2     
  Misses       1992     1992           
  Partials      124      124           
Flag Coverage Δ
javascript 68.43% <100.00%> (+0.01%) ⬆️
python 85.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeEmpress1
Copy link
Contributor

LGTM

@Lukewh Lukewh merged commit 423f235 into canonical:main Dec 13, 2023
10 checks passed
@Lukewh Lukewh deleted the publisher-header-consistency branch December 13, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants