Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture filter #4488

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add architecture filter #4488

merged 1 commit into from
Dec 14, 2023

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Dec 13, 2023

Done

Added an architecture filter to the beta store

How to QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-7856

@webteam-app
Copy link

Demo starting at https://snapcraft-io-4488.demos.haus

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1600647) 79.79% compared to head (d6f74af) 79.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4488   +/-   ##
=======================================
  Coverage   79.79%   79.79%           
=======================================
  Files         207      207           
  Lines       10474    10474           
  Branches      926      926           
=======================================
  Hits         8358     8358           
  Misses       1992     1992           
  Partials      124      124           
Flag Coverage Δ
javascript 68.43% <ø> (ø)
python 85.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@steverydz steverydz merged commit 6853bd7 into canonical:main Dec 14, 2023
10 checks passed
@steverydz steverydz deleted the add-architectures-filter branch December 14, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants