-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate eslint-plugin-jsx-a11y into the existing ESLint setup #4764
Open
chillkang
wants to merge
46
commits into
canonical:main
Choose a base branch
from
chillkang:WD-12366-integrate-eslint-plugin-jsx-ally-into-js-lint-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: integrate eslint-plugin-jsx-a11y into the existing ESLint setup #4764
chillkang
wants to merge
46
commits into
canonical:main
from
chillkang:WD-12366-integrate-eslint-plugin-jsx-ally-into-js-lint-configuration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillkang
changed the title
chore: install eslint-plugin-jsx-a11y as a development dependency
chore: integrate eslint-plugin-jsx-a11y into the existing ESLint setup
Jul 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4764 +/- ##
==========================================
- Coverage 66.80% 62.71% -4.09%
==========================================
Files 113 160 +47
Lines 3714 4144 +430
Branches 965 639 -326
==========================================
+ Hits 2481 2599 +118
- Misses 1098 1357 +259
- Partials 135 188 +53 |
…to-js-lint-configuration
…ation and seprate jsx-a11y linter from it
…configuration' of github.com:chillkang/snapcraft.io into WD-12366-integrate-eslint-plugin-jsx-ally-into-js-lint-configuration
2 tasks
…: off to the rules
…ublic chore: fix lint errors in static/js/public
…dstore chore: fix lint errors in static/js/brandstore
…rs-in-brandstore chore: fix remaining lint errors in brandstore
…rs-in-static/js/libs chore: fix remaining lint errors in static/js/libs
…-integrate-eslint-plugin-jsx-ally-into-js-lint-configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
eslint-plugin-jsx-a11y
and createeslint-a11y.config.js
file separately from.eslintrc.js
Reference: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y
lint-a11y
script topackage.json
andgithub actions workflow
.jsx
,.ts
, and.tsx
tolint-js
andlint-a11y
scriptsHow to QA
lint-js
andlint-a11y
checks should be failing now since new file extensions,.jsx
,.ts
, and.tsx
, were added. Before, we only got errors from.js
files.Ideas for the next steps?
1-1. Run ESLint with the
--fix
option1-2. Update configurations, e.g., use
prettier
alongside to fix style and formatting issues and disable the rule"rules": { "prettier/prettier": "error", "react/react-in-jsx-scope": "off" },
Testing
Issue / Card
Fixes #https://warthogs.atlassian.net/browse/WD-12366