Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameter that is sent to build endpoint #5011

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

ilayda-cp
Copy link
Contributor

Done

fix parameter that is sent to build endpoint

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-18976

@webteam-app
Copy link

} else {
formData.set(
"github_repository",
`${selectedOrg}/${selectedRepo.name}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be similar logic in validateRepo in line 45. Could that be somehow extracted and reused maybe?

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilayda-cp ilayda-cp merged commit cf95078 into main Feb 4, 2025
11 checks passed
@ilayda-cp ilayda-cp deleted the WD-18976-snap-with-org-issue-part2 branch February 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants