Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old Vanilla 2.0 related workarounds #5012

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Feb 4, 2025

Done

Cleaning old CSS workarounds (mostly around Vanilla 2.0 references):

  • removed custom p-logo-link styles (from unused first snap flow pages)
  • removed unused u-flex utility and all its outdated use in publisher header (utility itself has been replaced by u-flex-column in other places)
  • removed unnecessary workaround for code snippet issue
  • removed unnecessary z-index from release UI use of contextual menu

How to QA

image
  • Sign in, go to any snap Release UI, make sure contextual menu under Promote/Close still looks and works as expected:
image
  • Go to Publicise tab of any snap, make sure Markdown code snippets wrap the code
image

Testing

  • This PR has tests
  • No testing required (explain why): just visual changes

Issue / Card

Fixes WD-18868

@webteam-app
Copy link

<header class="p-card__header">
<img src="https://assets.ubuntu.com/v1/e95bac0c-tux.svg" alt="">
</header>
<div href="#" class="p-card u-align-text--center js-os-select" style="cursor: pointer;" data-os="linux">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit quick'n'dirty way to make this not look broken without removed p-logo-link.

These pages don't seem linked from anywhere anymore, and are supposed to be removed as part of WD-18896 anyway.

@bartaz bartaz changed the title WIP: remove vanilla 2 chore: Remove old Vanilla 2.0 related workarounds Feb 4, 2025
@bartaz bartaz marked this pull request as ready for review February 4, 2025 14:23
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bartaz bartaz merged commit 33ab674 into main Feb 4, 2025
11 checks passed
@bartaz bartaz deleted the WD-18868-remove-vanilla-2 branch February 4, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants