-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add explore page skeleton #5014
Open
steverydz
wants to merge
7
commits into
explore-page
Choose a base branch
from
WD-18954-add-explore-page-skeleton
base: explore-page
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Remove unused custom icons * chore: Replace custom icons with Vanilla equivalents
5257398
to
78dc4d8
Compare
78dc4d8
to
f7211cc
Compare
const searchRef = useRef<HTMLInputElement | null>(null); | ||
const searchSummaryRef = useRef<HTMLDivElement>(null); | ||
|
||
// Dummy data for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Inclusive naming check] reported by reviewdog 🐶
[warning] Dummy
may be insensitive, use placeholder
, sample
instead
* chore: Remove custom sticky footer * chore: Remove unnecessary u-no-limit and margin sizing utils * chore: Remove custom form validation styles * chore: Remove unnecessary strip variant * chore: Remove unnecessary breadcrumb override * bug: Fix button positioning in register form
f7211cc
to
df59b20
Compare
df59b20
to
0cd6206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Built out the skeleton of the explore page
Note: This won't actually work until the recommendation service is ready
How to QA
Testing
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-18954