Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add explore page skeleton #5014

Open
wants to merge 7 commits into
base: explore-page
Choose a base branch
from

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Feb 6, 2025

Done

Built out the skeleton of the explore page

Note: This won't actually work until the recommendation service is ready

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): Not a complete feature

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-18954

@webteam-app
Copy link

* chore: Remove unused custom icons

* chore: Replace custom icons with Vanilla equivalents
@steverydz steverydz force-pushed the WD-18954-add-explore-page-skeleton branch 7 times, most recently from 5257398 to 78dc4d8 Compare February 7, 2025 13:52
@steverydz steverydz force-pushed the WD-18954-add-explore-page-skeleton branch from 78dc4d8 to f7211cc Compare February 12, 2025 09:07
const searchRef = useRef<HTMLInputElement | null>(null);
const searchSummaryRef = useRef<HTMLDivElement>(null);

// Dummy data for now

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Inclusive naming check] reported by reviewdog 🐶
[warning] Dummy may be insensitive, use placeholder, sample instead

steverydz and others added 3 commits February 12, 2025 09:28
* chore: Remove custom sticky footer

* chore: Remove unnecessary u-no-limit and margin sizing utils

* chore: Remove custom form validation styles

* chore: Remove unnecessary strip variant

* chore: Remove unnecessary breadcrumb override

* bug: Fix button positioning in register form
@steverydz steverydz force-pushed the WD-18954-add-explore-page-skeleton branch from f7211cc to df59b20 Compare February 12, 2025 14:01
@steverydz steverydz changed the title WIP: feat: Add explore page skeleton feat: Add explore page skeleton Feb 12, 2025
@steverydz steverydz marked this pull request as ready for review February 12, 2025 14:01
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 6.81818% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (explore-page@5672a67). Learn more about missing BASE report.

Files with missing lines Patch % Lines
static/js/store/hooks/useCategories.ts 0.00% 8 Missing ⚠️
static/js/store/hooks/useNewSnaps.ts 0.00% 8 Missing ⚠️
static/js/store/hooks/usePopularSnaps.ts 0.00% 8 Missing ⚠️
static/js/store/hooks/useTopRatedSnaps.ts 0.00% 8 Missing ⚠️
static/js/store/hooks/useUpdatedSnaps.ts 0.00% 8 Missing ⚠️
...ic/js/store/components/SearchInput/SearchInput.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             explore-page    #5014   +/-   ##
===============================================
  Coverage                ?   52.39%           
===============================================
  Files                   ?      160           
  Lines                   ?     3577           
  Branches                ?      551           
===============================================
  Hits                    ?     1874           
  Misses                  ?     1566           
  Partials                ?      137           
Files with missing lines Coverage Δ
static/js/base/ga.ts 22.58% <ø> (ø)
.../js/publisher/components/Navigation/Navigation.tsx 46.00% <ø> (ø)
static/js/store/pages/Store/Store.tsx 93.33% <ø> (ø)
...ic/js/store/components/SearchInput/SearchInput.tsx 83.33% <75.00%> (ø)
static/js/store/hooks/useCategories.ts 0.00% <0.00%> (ø)
static/js/store/hooks/useNewSnaps.ts 0.00% <0.00%> (ø)
static/js/store/hooks/usePopularSnaps.ts 0.00% <0.00%> (ø)
static/js/store/hooks/useTopRatedSnaps.ts 0.00% <0.00%> (ø)
static/js/store/hooks/useUpdatedSnaps.ts 0.00% <0.00%> (ø)

@steverydz steverydz force-pushed the WD-18954-add-explore-page-skeleton branch from df59b20 to 0cd6206 Compare February 12, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants