ci(appveyor): fix pyinstaller

appveyor.yml

@@ -27,7 +27,7 @@ build_script:
 - cmd: |
     echo "Building snapcraft.exe..."
     venv\Scripts\activate.bat
-    pyinstaller.exe --copy-metadata lazr.restfulclient --onefile snapcraft.spec
+    pyinstaller.exe snapcraft.spec
     venv\Scripts\deactivate.bat
 
     echo "Test signing snapcraft.exe..."

requirements-devel.txt

@@ -129,4 +129,4 @@ zope.deprecation==5.0
 zope.interface==6.1
 python-apt @ https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/python-apt/2.4.0ubuntu1/python-apt_2.4.0ubuntu1.tar.xz; sys.platform == "linux"
 setuptools<66
-pyinstaller==4.10; sys.platform == "win32"
+pyinstaller==5.13.1; sys.platform == "win32"

snapcraft_legacy/internal/dirs.py

@@ -49,7 +49,7 @@ def _find_windows_data_dir(topdir):
     # > c:\program files\python37\share\snapcraft
 
     # Handle Option (a).
-    if topdir.startswith(site.USER_BASE):
+    if site.USER_BASE and topdir.startswith(site.USER_BASE):
         data_dir = os.path.join(site.USER_BASE, "share", "snapcraft")
         if os.path.exists(data_dir):
             return data_dir

tools/freeze-requirements.sh

@@ -13,7 +13,7 @@ requirements_fixups() {
   # Pinned pyinstaller for windows.
   if [[ "$req_file" == "requirements-devel.txt" ]]; then
       sed -i '/pyinstaller/d' "$req_file"
-      echo 'pyinstaller==4.10; sys.platform == "win32"' >> "$req_file"
+      echo 'pyinstaller==5.13.1; sys.platform == "win32"' >> "$req_file"
   fi
 }