Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): make python-apt requirement match rockcraft #4497

Closed
wants to merge 2 commits into from

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Dec 13, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

driveby: makes pyinstaller freeze more obvious.

Requires #4490

fixes #4496

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89961cf) 89.18% compared to head (778177e) 89.20%.

❗ Current head 778177e differs from pull request most recent head 7d7299c. Consider uploading reports for the commit 7d7299c to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4497      +/-   ##
==========================================
+ Coverage   89.18%   89.20%   +0.02%     
==========================================
  Files         321      321              
  Lines       21777    21755      -22     
==========================================
- Hits        19421    19406      -15     
+ Misses       2356     2349       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lengau lengau requested review from mr-cal and sergiusens December 13, 2023 19:03
@lengau lengau marked this pull request as ready for review December 13, 2023 19:03
@lengau lengau requested a review from cmatsuoka December 13, 2023 22:16
@lengau lengau force-pushed the 4496/update-requirements branch from 7c82aa1 to 818feb0 Compare December 15, 2023 22:25
@lengau lengau force-pushed the 4496/update-requirements branch 2 times, most recently from 778177e to 32ee5f9 Compare January 10, 2024 23:53
Driveby: makes `pyinstaller` freeze more obvious.
Driveby: makes `pyinstaller` freeze more obvious.
@lengau lengau force-pushed the 4496/update-requirements branch from 32ee5f9 to 7d7299c Compare January 31, 2024 14:32
@lengau lengau closed this Feb 1, 2024
@lengau lengau deleted the 4496/update-requirements branch February 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronise python-apt dependency with other starcraft projects
3 participants