Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limit marketo endpoint #14569

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Rate limit marketo endpoint #14569

wants to merge 6 commits into from

Conversation

samhotep
Copy link
Member

@samhotep samhotep commented Dec 13, 2024 •
edited
Loading

Done

  • Added rate limiting to the marketo endpoint

QA

  • Fill out a marketo form and submit in intervals of 8s and 16s and 32s. The request should return a 429 error.
  • Wait for another 8s and make another request, This one should pass through.

Issue / Card

Fixes WD-15861

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@petesfrench
Copy link
Contributor

QA result: I was able to hit the rate limit and throw a 429 once, but after that was unable to hit it again

@samhotep
Copy link
Member Author

@petesfrench I have made an update to fix this, could you please try again?

@petesfrench
Copy link
Contributor

QA results: This time I wasn't able to hit the rate limit at all

@samhotep
Copy link
Member Author

@petesfrench I've reworked it a bit, and added some optional params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samhotep @webteam-app @petesfrench