Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh /pricing/pro #14756

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Feb 19, 2025

Done

  • Remove "swift" from Ceph section.
  • Updated Ubuntu version for "NIST-certified FIPS crypto-modules"
  • Add free pro section (this will need a design review as I couldn't find any examples of tables behind accordions).

https://docs.google.com/document/d/1Ynk0iLa9hjrdich6ATTsybtPbDwW_k4vRI0nk_HNhcI/edit?tab=t.0#heading=h.2yomf46629v0

QA

  • Go to /pricing/pro.
  • See that Ubuntu Pro for personal users section has been added at the top.
  • Click 'Ubuntu Pro for personal users' and the table should appear.
  • Look for the "NIST-certified FIPS crypto-modules" text in the "Security and compliance" table and check that the muted text has been updated to "24.04".
  • Scroll down and check that "swift" has been removed from the Ceph section (halfway down the page).

Issue / Card

https://warthogs.atlassian.net/browse/WD-19413

Screenshots

Screenshot 2025-02-19 at 12 30 37 pm Screenshot 2025-02-19 at 12 35 12 pm

@webteam-app
Copy link

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (82e4833) to head (248beca).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14756      +/-   ##
==========================================
+ Coverage   71.87%   71.93%   +0.05%     
==========================================
  Files         120      120              
  Lines        3431     3431              
  Branches     1179     1181       +2     
==========================================
+ Hits         2466     2468       +2     
+ Misses        935      933       -2     
  Partials       30       30              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kim-isaac
Copy link

kim-isaac commented Feb 27, 2025

Hi @huwshimi , I have one suggestion from visual side

Screenshot 2025-02-27 at 12 19 11

  • Could you align the last column of the table inside of the accordion with the table below like this?

@huwshimi
Copy link
Contributor Author

@kim-isaac done! Is there anything else from the design side or can this move on to code review?

Screenshot 2025-02-28 at 9 39 05 am

@huwshimi huwshimi marked this pull request as ready for review February 27, 2025 22:39
@kim-isaac
Copy link

Hi @huwshimi , thanks for the work! Has it been updated on the demo site as well? Even after clearing cookies and site data, I’m still seeing the previous version. Also, before moving to code review, it’d be great to get @Sophie-32 ’s UX review. I’ll add the relevant label.

@huwshimi
Copy link
Contributor Author

huwshimi commented Mar 2, 2025

@kim-isaac oops I'm sorry I've pushed it properly now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants