Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security web: add esm-infra-legacy pockets WD-17330 WD-19534 #14806

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rodrigoffzz
Copy link

Done

  • we need the "Available with Ubuntu Pro" tag for the pocket "esm-infra-legacy" as we have for "esm-infra";
  • esm-infra-legacy pocket already exists in https://github.com/canonical/ubuntu-com-security-api and is being pushed by the security team for a while;
  • without this tag there is no indication that an update is placed in a different place and could be mislead our users
  • for now, I don't see a need to add this pocket in other places like Entitlements and in the list of products in the ubuntu advantage category, this feels like a commercial discussion which I don't want to drive here in this PR

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-17330
Fixes https://warthogs.atlassian.net/browse/WD-19534

Screenshots

A test for the CVE webpage with the text added (the text has changed, but the idea remains)
image

Help

QA steps - Commit guidelines

 suggesting the addition of esm-infra-legacy pockets to cves and usns
 webpages so we can have the hyperlink to Ubuntu Pro and the note
 about this pocket. It is not a new pocket, it is already known in
 the ubuntu-com-security-api and it is being pushed to our websites
 already, we are just missing the information as we have for esm-infra

Signed-off-by: Rodrigo Figueiredo Zaiden <[email protected]>
@webteam-app
Copy link

rodrigoffzz is not a collaborator of the repo

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (4bf8f5c) to head (5ced7fa).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14806      +/-   ##
==========================================
- Coverage   71.95%   71.93%   -0.03%     
==========================================
  Files         120      120              
  Lines        3430     3431       +1     
  Branches     1179     1179              
==========================================
  Hits         2468     2468              
- Misses        932      933       +1     
  Partials       30       30              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants