Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : change font in blog website #110

Merged
merged 1 commit into from
Sep 8, 2023
Merged

refactor : change font in blog website #110

merged 1 commit into from
Sep 8, 2023

Conversation

cp-mansi-d
Copy link
Collaborator

@cp-mansi-d cp-mansi-d commented Aug 10, 2023 •
edited
Loading

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

Design should be tested on:

  • Inspector (all iPhones and android devices like samsung, motorola)
  • Desktop (chrome, firefox, safari)
  • Laptop / Macbook (chrome, firefox, safari)
  • iPhone(safari)
  • Available android devices (chrome, firefox)
  • iPad(safari)
  • Tablet (chrome, firefox)

Description

  • change fonr style in whole blog website.
  • another some changes related font.
  • change some font opacity in title section and also in sharing icons.
  • also tried to used default tailwind classes ,if possible

@cp-mansi-d cp-mansi-d force-pushed the change-font-style-in-blog branch 4 times, most recently from 30b2040 to 09502fa Compare August 10, 2023 14:03
cp-jagruti-a
cp-jagruti-a reviewed Aug 11, 2023
View reviewed changes
pages/index.js Outdated Show resolved Hide resolved
@cp-mansi-d cp-mansi-d force-pushed the change-font-style-in-blog branch 4 times, most recently from 613a08a to a846ef1 Compare August 11, 2023 07:37
@cp-mansi-d cp-mansi-d force-pushed the change-font-style-in-blog branch 2 times, most recently from c33c849 to d128b4a Compare August 15, 2023 05:00
@cp-mansi-d cp-mansi-d force-pushed the change-font-style-in-blog branch 2 times, most recently from f6e3b65 to 95be8f6 Compare September 1, 2023 11:52
@cp-mansi-d cp-mansi-d force-pushed the change-font-style-in-blog branch 5 times, most recently from c608bc8 to 8623b48 Compare September 8, 2023 04:50
@cp-mansi-d cp-mansi-d force-pushed the change-font-style-in-blog branch from 8623b48 to 4b1684c Compare September 8, 2023 05:20
@cp-mansi-d cp-mansi-d merged commit 0628cbb into main Sep 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-priyanka-g cp-priyanka-g cp-priyanka-g approved these changes

@cp-jagruti-a cp-jagruti-a cp-jagruti-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cp-mansi-d @cp-jagruti-a @cp-priyanka-g