Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix author validation issue #161

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix author validation issue #161

merged 1 commit into from
Jun 27, 2024

Conversation

cp-dharti-r
Copy link
Collaborator

@cp-dharti-r cp-dharti-r commented Jun 27, 2024 •
edited
Loading

Review checklist

Note: Make sure all points should be checked before submiting PR for review, otherwise PR will be cosidered invalid.

  • Follow guidelines for creating branch name, adding commit messages or PR title
  • Add MR description if applicable
  • Follow guidelines for naming conventions everywhere (i.e files/folders, data structures)
  • Reuse code (if the same code is written twice, make it common and reuse it at both places)
  • Remove unused or commented code if not required
  • Make MR self-approved - review MR as a reviewer and give it self-approval if everything is ok, if not make the required changes
  • In progress MR should be marked as draft
  • Make MR mark as ready before submitting it for review
  • Add images, videos, or gifs of UI
  • Add page speed score screenshot of UI (It should be > 85 for mobile and > 90 for desktops)

PR Description

  • Fix author validation issue
  • Fix publish unpublish validation required issue

@cp-dharti-r cp-dharti-r changed the title Fix update form author issue Fix author validation issue Jun 27, 2024
@cp-dharti-r cp-dharti-r force-pushed the fix-update-form-author-issue branch from c2b8009 to 9c0e070 Compare June 27, 2024 10:33
@cp-dharti-r cp-dharti-r force-pushed the fix-update-form-author-issue branch from 9bad5a2 to 08b4a55 Compare June 27, 2024 11:01
@cp-dharti-r cp-dharti-r merged commit d037e0a into main Jun 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp-sumi-k cp-sumi-k cp-sumi-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-dharti-r @cp-sumi-k