Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show events on home screen #78

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix show events on home screen #78

merged 1 commit into from
Mar 21, 2024

Conversation

cp-sneha-s
Copy link
Collaborator

@cp-sneha-s cp-sneha-s commented Mar 21, 2024

Purpose

  • Fix: Events are not showing on the screen

Summary by CodeRabbit

  • Refactor
    • Improved initialization of the EmployeeRepo for better performance and reliability.
  • Tests
    • Added a new mock class for EmployeeRepo to enhance testing capabilities.

Copy link

coderabbitai bot commented Mar 21, 2024

Walkthrough

The recent updates transition the EmployeeRepo from a lazily initialized singleton to a strictly initialized one, affecting its instantiation and ensuring non-null returns for employee data. Additionally, a new mock class for EmployeeRepo has been introduced to facilitate testing, employing Mockito for mock generation.

Changes

File Path Change Summary
.../di/service_locator.config.dart Changed EmployeeRepo initialization from lazySingleton to singleton.
.../repo/employee_repo.dart Updated EmployeeRepo to a strict singleton and modified allEmployees getter for non-null returns.
.../unit_test/shared/events/...mocks.dart Introduced MockEmployeeRepo for testing, providing mocked methods for employee data operations.

🐰✨
In the realm of code where the rabbits dwell,
An update was made, oh hear the bell!
From lazy to strict, the singleton stands tall,
With mocks in the field, ensuring a call.
No nulls in the sight, the data flows right,
A hop, skip, and jump into the test's delight.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@cp-sneha-s cp-sneha-s merged commit c0e33d7 into main Mar 21, 2024
1 check passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ed88e47 and 1f47c7c.
Files selected for processing (3)
  • lib/data/di/service_locator.config.dart (1 hunks)
  • lib/data/repo/employee_repo.dart (2 hunks)
  • test/unit_test/shared/events/celebration_event_bloc_test.mocks.dart (1 hunks)
Files skipped from review due to trivial changes (1)
  • test/unit_test/shared/events/celebration_event_bloc_test.mocks.dart
Additional comments: 3
lib/data/repo/employee_repo.dart (2)
  • 10-10: The change from @LazySingleton() to @Singleton() is appropriate for services that are intended to be shared across the application. However, it's important to consider the implications on memory usage and lifecycle management.
  • 37-42: The modification to ensure _employeeController has a value before returning enhances the method's robustness. Consider adding a comment explaining that an empty list is returned when there's no value, for clarity.
lib/data/di/service_locator.config.dart (1)
  • 275-276: Switching EmployeeRepo to a singleton in the dependency injection configuration is a significant change. Ensure thorough testing is conducted to verify that this does not introduce any unintended side effects, particularly regarding memory management and the application's lifecycle.

@cp-sneha-s cp-sneha-s deleted the fix-events branch March 21, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant