Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo improvement #66

Closed
wants to merge 5 commits into from
Closed

Repo improvement #66

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b697a52
Repo improvement
cp-pratik-k Dec 13, 2024
2d987ba
Repo improvement
cp-pratik-k Dec 13, 2024
c47c923
Test
cp-pratik-k Dec 13, 2024
a972fea
Test record error
cp-pratik-k Dec 13, 2024
56d971c
Test record error
cp-pratik-k Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ios_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
name: Publish to App Store Connect

on:
push:
branches:
- main
workflow_dispatch:
on: push
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical: Restrict deployment triggers to production-ready branches

The current trigger configuration will run the deployment workflow on any push to any branch, which could lead to unintended deployments to App Store Connect. This is particularly risky for a production deployment workflow.

Consider restricting the workflow to run only on production-ready branches and tags:

-on: push
+on:
+  push:
+    branches:
+      - main
+      - release/*
+    tags:
+      - 'v*'
+  workflow_dispatch:  # Allow manual triggers for flexibility
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
on: push
on:
push:
branches:
- main
- release/*
tags:
- 'v*'
workflow_dispatch: # Allow manual triggers for flexibility


jobs:
ios_deploy:
Expand Down
30 changes: 0 additions & 30 deletions .idea/libraries/Dart_Packages.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions ...flow/media_preview/components/network_image_preview/network_image_preview_view_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,10 @@ class NetworkImagePreviewStateNotifier
}

@override
void dispose() {
tempFile?.deleteSync();
void dispose() async {
if (tempFile != null && await tempFile!.exists()) {
await tempFile!.delete();
}
Comment on lines +93 to +96
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Consider calling super.dispose() first

While the async file cleanup is a good improvement, calling super.dispose() after async operations can be problematic as the parent class might be disposed while operations are still pending.

Consider this refactor:

-void dispose() async {
+@override
+Future<void> dispose() async {
+  super.dispose();
   if (tempFile != null && await tempFile!.exists()) {
     await tempFile!.delete();
   }
   cancelToken?.cancel();
-  super.dispose();
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
void dispose() async {
if (tempFile != null && await tempFile!.exists()) {
await tempFile!.delete();
}
@override
Future<void> dispose() async {
super.dispose();
if (tempFile != null && await tempFile!.exists()) {
await tempFile!.delete();
}
cancelToken?.cancel();
}

cancelToken?.cancel();
super.dispose();
}
Expand Down
2 changes: 2 additions & 0 deletions data/lib/repositories/media_process_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,8 @@ class MediaProcessRepo extends ChangeNotifier {
return;
}

rethrow;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Maintain consistent error handling across providers

The error handling differs between Google Drive and Dropbox downloads. While Google Drive rethrows the error, Dropbox silently handles it. This inconsistency could lead to different behavior depending on the provider.

Consider applying the same error handling pattern to both providers. Either:

  1. Add rethrow to Dropbox download (if errors need to be handled by callers)
  2. Remove rethrow from Google Drive download (if errors should be handled locally)

The choice depends on whether the calling code needs to handle these errors.

⚠️ Potential issue

Fix error handling flow

The rethrow statement is placed before the error notification and status update, which means these important error handling steps will never execute. This could leave the UI in an inconsistent state and the user uninformed about the failure.

Consider this fix:

    } catch (error) {
      if (error is DioException && error.type == DioExceptionType.cancel) {
        showNotification('Download from Google Drive cancelled');
        return;
      }

-     rethrow;
-
      showNotification('Failed to download from Google Drive');

      await updateDownloadProcessStatus(
        status: MediaQueueProcessStatus.failed,
        id: process.id,
      );
+     rethrow;
    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
rethrow;
if (error is DioException && error.type == DioExceptionType.cancel) {
showNotification('Download from Google Drive cancelled');
return;
}
showNotification('Failed to download from Google Drive');
await updateDownloadProcessStatus(
status: MediaQueueProcessStatus.failed,
id: process.id,
);
rethrow;

showNotification('Failed to download from Google Drive');

await updateDownloadProcessStatus(
Expand Down
Loading