Include S3 object content type in attributes #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garyttierney Can you rebase this on the latest version of develop? That ought to fix the test failures. |
garyttierney
force-pushed
the
bugfix/s3-content-type
branch
from
9ce4ddc to
155c3e4
Compare
|
@jcoyne yep, done! |
|
Glen to look at suggested issues:
Glen to look into this issue. |
|
Closing in favour of #700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ContentTypeHeaderCheckeris invoked after theNameChecker, but thecontentTypeis never set when the attributes are fetched from S3. This patch fixes that.