Support different storage #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvanu
force-pushed
the
support-different-storage
branch
from
c02ed27
to
314f6ee
Compare
crazytaxii
reviewed
Apr 24, 2024
config.yaml
Outdated
| log_format: json | ||
|
|
||
| db: | ||
| type: sqlite |
There was a problem hiding this comment.
冗余信息，只有 sqlite 而没有 mysql 就已经能说明要连接 sqlite 类型的数据库了
crazytaxii
reviewed
Apr 24, 2024
cmd/app/config/config.go
Outdated
| return err | ||
| } | ||
| type DbConfig struct { | ||
| Type string `yaml:"type"` |
There was a problem hiding this comment.
Type 是冗余信息，mysql 和 sqlite 字段用指针
crazytaxii
reviewed
Apr 24, 2024
| @@ -107,7 +108,7 @@ func (c *cluster) Create(ctx context.Context, req *types.CreateClusterRequest) e | |||
| } | |||
|
|
|||
| var cs *client.ClusterSet | |||
| var txFunc db.TxFunc = func() (err error) { | |||
There was a problem hiding this comment.
var txFunc = func() error 去掉类型，没必要为它多写一个包
There was a problem hiding this comment.
这个是之前既有的类型定义，在db包下。
新开一个包写它也是为了解决循环依赖
crazytaxii
reviewed
Apr 24, 2024
pkg/db/iface/tenant.go
Outdated
| package iface | ||
|
|
||
| import ( | ||
| "context" |
crazytaxii
reviewed
Apr 24, 2024
pkg/db/iface/tenant.go
Outdated
| @@ -0,0 +1,32 @@ | |||
| /* | |||
There was a problem hiding this comment.
开源许可证在写完后，用 make licfmt 生成
crazytaxii
reviewed
Apr 24, 2024
cmd/app/config/config.go
Outdated
Comment on lines
80
to
89
| func (c *Config) Valid() (err error) { | ||
| if err = c.Default.Valid(); err != nil { | ||
| return | ||
| } | ||
| if err = c.Mysql.Valid(); err != nil { | ||
| return | ||
| } | ||
| return | ||
| func (c *Config) Valid() error { | ||
| return nil |
There was a problem hiding this comment.
要把自己负责的部分的校验逻辑加进来，而不是删掉原先已存在的校验逻辑
crazytaxii
reviewed
Apr 24, 2024
pkg/db/factory.go
Outdated
Comment on lines
29
to
33
| type ShareDaoFactory interface { | ||
| Cluster() ClusterInterface | ||
| Tenant() TenantInterface | ||
| User() UserInterface | ||
| } | ||
|
|
||
| type shareDaoFactory struct { | ||
| db *gorm.DB | ||
| Cluster() iface.ClusterInterface | ||
| Tenant() iface.TenantInterface | ||
| User() iface.UserInterface | ||
| } |
There was a problem hiding this comment.
没必要另起文件，ClusterInterface TenantInterface UserInterface 就该在原来的文件中
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: