feat: Expose services of type dataProduct special #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramovic79
commented
Feb 17, 2025
aramovic79
commented
Feb 17, 2025
lib/templates.js
Outdated
Comment on lines
279
to
294
| apiProtocol: "api", | ||
| visibility: RESOURCE_VISIBILITY.internal, | ||
| direction: "outbound", | ||
| implementationStandard: "sap.dp:data-subscription-api:v1", | ||
| entryPoints: [], | ||
| resourceDefinitions: [{ | ||
| type: "sap-csn-interop-effective-v1", | ||
| mediaType: "application/json", | ||
| url: "<TBD>/Product.csn.json", | ||
| accessStrategies: [ | ||
| { | ||
| type: "open" | ||
| } | ||
| ] | ||
| }] | ||
| } |
There was a problem hiding this comment.
All the values here are hard-coded.
At least one property should be calculated based on some information coming from the concrete annotated service.
The property "url" is to be defined.
Value(s) of the "accessStrategies" property are obtained and calculated out of environment variables or .cdsrc.json(done in PR 111).
cc: @swennemers @zongqichen
aramovic79
commented
Feb 17, 2025
lib/templates.js
Outdated
| * @returns {Array} An array of objects for the API Resources. | ||
| */ | ||
| const createDataProductAPIResourceTemplate = (dataProduct) => { | ||
| console.log(dataProduct); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.