Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.14.2 #345

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Release v0.14.2 #345

merged 4 commits into from
Oct 30, 2024

Commits on Oct 29, 2024

  1. Fix comparison report when one column is all NAs (#343)

    * Fix compariosn report when one column is all NAs
    
    With situations when one of the column in the comparison was
    all NA's then this would break the reporting. For some reason
    when the matching (boolean) of the actual and expected columns happened when there was a categorical value compared to a NA, the result was NA, rather than False, as it would happen for the other elements in the cols compared.
        
    This has now been addressed at the intersect rows level which doesn't seem to break the reporting anymore.
    
    * Fix column_equal to work with StringArrays with pd.NA values not returning booleans
    
    * Add test for fn column_equal to work with StringArrays with pd.NA 
    
    Add test for fn column_equal to work with StringArrays containing pd.NA values not returning booleans when compared with other df's with rows of StringArrays
    
    * Fix linter error
    
    Printing out the report would've been useful for this test, but looks like it makes the linter fail the build. This has now been fixed.
    
    * Fix column_equal to work with StringArrays with pd.NA values
    
    Fix column_equal to work with StringArrays with pd.NA values not returning booleans, and update formatting to match the linter expectation
    
    * Add test for fn column_equal to work with StringArrays with pd.NA
    
    Add test for fn column_equal to work with StringArrays containing pd.NA values not returning booleans when compared with other df's with rows of StringArrays, and format test to match the linter.
    yozzo authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1013ca8 View commit details
    Browse the repository at this point in the history
  2. Adding SnowflakeCompare (Snowflake/Snowpark compare) (#333)

    * adding snowflake/snowpark compare
    
    * undo change
    
    * add partial case sensitive support
    
    * update doc
    
    * pr comments
    
    * remainder PR comments
    
    * update readme
    
    * mocking abs, trim
    
    * remove local testing, fix text
    
    * ignore snowflake tests
    
    * catch snowpark import in test config
    
    * python 3.12 actions without snowflake
    
    * clean
    
    * fix
    
    * catch snowflake imports, fix snowflake type annotations
    
    * conditional install
    
    * conditional install
    
    * conditional install
    
    * fix conditional
    rhaffar authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    1ea649a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Snowflake compare annotation fix, add docs (#344)

    * changes
    
    * doc fix
    
    * version bump
    rhaffar authored Oct 30, 2024
    Configuration menu
    Copy the full SHA
    223b61c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39ef330 View commit details
    Browse the repository at this point in the history