Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remaining dataclasses - warn on extra kwargs #476

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Conversation

ryanSoley
Copy link
Member

@ryanSoley ryanSoley commented Aug 16, 2024

follow up to #474, #475

What

  • overrides the domain Artifact, Dataframe, Feature, Metric, and Parameter's dataclass-created __init__s
    • warn on unexpected kwargs rather than error to support forwards and backwards compatibility across changes to the rubicon-ml data model
    • from this point forward, any rubicon-ml library version should be able to read domain entities from disk written by any other rubicon-ml library version (assuming only the data model changes, not the way the library itself reads data)

How to Test

  • python -m pytest tests/unit/domain/test_domain.py

Base automatically changed from update-dataclasses to main August 16, 2024 19:38
@ryanSoley ryanSoley marked this pull request as ready for review August 16, 2024 19:42
@ryanSoley ryanSoley requested review from a team as code owners August 16, 2024 19:42
@ryanSoley ryanSoley self-assigned this Aug 16, 2024
@ryanSoley ryanSoley added the enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs. label Aug 16, 2024
@ryanSoley ryanSoley merged commit 1b1c324 into main Aug 20, 2024
7 checks passed
@ryanSoley ryanSoley deleted the update-dataclasses-pt2 branch August 20, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants