pass s3 storage options to dataframe read/write #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanSoley
commented
Sep 19, 2024
| @@ -614,7 +616,7 @@ def _persist_dataframe( | |||
| df.write_parquet(path) | |||
There was a problem hiding this comment.
polars only seems to offer storage option input on read, not write
https://docs.pola.rs/api/python/stable/reference/api/polars.DataFrame.write_parquet.html
dianelee217
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
storage_optionswere only being passed tofsspecfor standard file read/writestorage_optionsmust be empty for non-remote storage or pandas and dask will errorHow to Test
python -m pytest tests