-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for maxcompute as source type (batch) #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7c55f6
to
bc0658b
Compare
e0b3dda
to
bc0658b
Compare
deadlycoconuts
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for poking around the entire Feast codebase, for picking up scala too and of course testing these changes just to get this PR up! I just left a couple of tiny comments but feel free to merge this PR whenever you're satisfied with the changes 🚀
caraml-store-registry/src/main/java/dev/caraml/store/feature/DataSourceValidator.java
Show resolved
Hide resolved
caraml-store-registry/src/main/java/dev/caraml/store/sparkjob/adapter/DataSourceConverter.java
Show resolved
Hide resolved
caraml-store-sdk/python/dist/caraml_store-0.3.1.dev4+gd80e503.d20250114-py3-none-any.whl
Outdated
Show resolved
Hide resolved
caraml-store-sdk/python/dist/caraml-store-0.3.1.dev4+gd80e503.d20250114.tar.gz
Outdated
Show resolved
Hide resolved
caraml-store-spark/src/main/scala/dev/caraml/spark/sources/maxCompute/MaxComputeReader.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in MR are to enable MaxCompute as a datasource type for batch jobs (offline to online ingestion)
With these changes, record with batch_source maxcompute is added to the datasources table
postgres=> select * from data_sources;
42 | BATCH_MAXCOMPUTE | {"table_ref":"datasource:playground.dsp_maxcompute_dogfood"} | {} | created_timestamp | created_timestamp |